Lecrapouille / gdcef

[Plugin][Version 0.10.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4
https://discord.gg/EckEwy7S5U
MIT License
222 stars 26 forks source link

Widevine support? #28

Open monkeyman192 opened 1 year ago

monkeyman192 commented 1 year ago

Hello! I have managed to get this extension built and running with godot 3.5, but was wondering if there is some way to get widevine CDM support? I am currently testing on windows 10. I have tried to follow the instructions here to get the latest dll and place it in the appropriate folder and nothing happened. I have also found this however I don't think I can pass in "enable-widevine-cdm" as a config argument for this?

Any help or insight would be appreciated 😄

Lecrapouille commented 1 year ago

@monkeyman192 I'm sorry I know nuts about widevine (I have not yet head about it). https://peter.sh/experiments/chromium-command-line-switches/ Concerning https://magpcss.org/ceforum/viewtopic.php?f=6&t=16080 my knowledge in CEF starts to be rusty since I made long time I did not develop wrapper classes for Godot, but CefCommandLineArgs is not made for what you think. For what I remember (for what I understood reading the cefclient code example gdcef/addons/gdcef/thirdparty/cef_binary/tests/cefclient/), it's used to pass information to forked CEF processes like if you have pass command line directly to your Chromium application but does not make it active because you have to add some code and manage it (command line is to tell that you want this feature, but internally you have to set CEF settings to enable it) and that is why I does not offer API CefCommandLineArgs in GDcef because in my opinion this is totally useless). So yep this will not help you to make it working.

If I understood well from https://www.magpcss.org/ceforum/viewtopic.php?f=6&t=17719 you should give the widevine extension to CEF. I started to implement plugins on our previous project https://github.com/stigmee/gdnative-cef/commit/55c10704bca3bdd98a6160ffc49be301737ba8cb since we implemented an extension, but I never finished because 1/ the coworker who made our extension never made it officially for version 2 (CEF only accept extension version 2 and now people use version 3, see https://magpcss.org/ceforum/viewtopic.php?f=6&t=10242) and my modified v2 extension worked only for CEFsimple gdcef/addons/gdcef/thirdparty/cef_binary/tests/cefsimple because I missed some functions in my code to make gdcef ables to load extension. In addition cef_web_plugin.h seems no longer exist.

Anyway adding extension for GDCEF can be nice to add some add block plugins.

Lecrapouille commented 1 year ago

https://bitbucket.org/chromiumembedded/cef/issues/3149/alloy-add-component-updater-support-for from https://github.com/cefsharp/CefSharp/issues/3767