Lecrapouille / gdcef

[Plugin][Version 0.13.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4
https://discord.gg/EckEwy7S5U
MIT License
268 stars 31 forks source link

Documentation correction/simplification #4

Closed raphipod closed 2 years ago

raphipod commented 2 years ago

This pull request is only dedicated to correcting language mistakes and simplyfing the README file & maybe some docs

The README file correcting is done as is, now I will search for other things to be corrected especially in the /doc folder.

Note: I won't add any content to any of those files, it's just some corrections. I don't quite know yet how this project works underneath, but maybe I'll give it a shot in the next PR's.

Lecrapouille commented 2 years ago

@raphipod thank you ! My English is poor :) and the detail design is unfinished because I left before ended writing it.

raphipod commented 2 years ago

Ah, ok. No worries.

raphipod commented 2 years ago

Allright. I think I've done everything I wanted to do. PR 0af0435 just updated the CEF version, while I was at it.

We could maybe switch to Godot 3.5, I'll have a look into it.

Ready to merge!

Lecrapouille commented 2 years ago

@raphipod Yes we can try to switch to Godot 3.5 by changing this line: https://github.com/Lecrapouille/gdcef/blob/1a2a27a961325bae7bee48fd854743104301f827/build.py#L324 But I will not be able to test until end of August