search

Lecrapouille / gdcef

[Plugin][Version 0.10.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4
https://discord.gg/EckEwy7S5U
MIT License
222 stars 26 forks source link

audio bus output #42

Closed Loudened closed 7 months ago

Loudened commented 7 months ago

This is really awesome. The best CEF attempt so far :) Is there a way to grab the audio stream from CEF and pipe it through a Godot audio bus, so that we can make it 3d positional?

Lecrapouille commented 7 months ago

@Loudened maybe this commit https://github.com/Lecrapouille/gdcef/pull/31 but since I git rebased the project GitHub failed showing the diff, but the PR did not pass my code review at this epoch lol. Here is the initial commit https://github.com/pixaline/gdcef/commit/e99d5b1743ed701468743417e98a5f0a5ad9eb67**

Loudened commented 7 months ago

Ah yes! This looks like exactly what I mean. Although also looks like it's not compatible with the current branch and no-one has worked on it for some time :(

Lecrapouille commented 7 months ago

It's working I added @pixaline PR but currently, I cannot swap between pure CEF audio and routing audio to Godot. Once one is selected, we cannot swap to second mode.

Edit: ah ok I understand now: if you select one mode, to swap of mode you have to pause/play the html bouton of the page

Lecrapouille commented 7 months ago

@Loudened I committed in branch https://github.com/Lecrapouille/gdcef/tree/dev-audio-routing, demo 2D, tell me if OK for you I'll merge in main branches.

Lecrapouille commented 7 months ago

Oups! in this branch my C++ got a typo inside a "if" and Godot segfault. I will merge routing sound in the godot-4 branch. Updated demos with AudioStreamPlayer2D and AudioStreamPlayer3D respectively

Loudened commented 7 months ago

Thank you @Lecrapouille