search

Lecrapouille / gdcef

[Plugin][Version 0.13.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4
https://discord.gg/EckEwy7S5U
MIT License
266 stars 31 forks source link

Need to pass modifiers in all mouse events #44

Closed g012 closed 8 months ago

g012 commented 9 months ago

Hey hey,

I haven't actually used your plugin, but I used your source as reference for integrating CEF into my project - thanks ! I have loaded mapbox in the embedded browser, and I noticed I couldn't drag the map, and it was zooming at 0,0 with the wheel : the issue was that CefMouseEvent::modifiers must be filled for each mouse event (click, move, wheel). So I'm pretty sure you have the same issue with this plugin. You need to save the modifiers in GDBrowserView and pass them in each m_browser->GetHost()->SendMouse*() in browser_io.cpp.

Cheers

Lecrapouille commented 9 months ago

@g012 Thanks for the report, I'll check it when I'll time (currently I have few). Can you make a pull request ?