Improved onPaint performance

Lecrapouille / gdcef

[Plugin][Version 0.10.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4

https://discord.gg/EckEwy7S5U

MIT License

222 stars 26 forks source link

Improved onPaint performance #48

Closed eliopark-nsuslab closed 5 months ago

eliopark-nsuslab commented 5 months ago

Use dirtyRects instead of the whole image when onPaint()
Use concurrency::parallel_for to take advantage of multiple cores

eliopark-nsuslab commented 5 months ago

I used but I don't know if it's available on Linux, the github build passed. I only tested it on windows.

Lecrapouille commented 5 months ago

@eliopark-nsuslab thanks again, I was busy ! I'll test it on Linux tonight :)

Lecrapouille commented 5 months ago

@eliopark-nsuslab Concerning ppl.h I do not have it on my Debian they offer ppl.hh :( I dunno why it compiles on my CI (ubuntu). Why not using openmp ?

Lecrapouille commented 5 months ago

@eliopark-nsuslab hummmm when merging your commit the Linux CI finally failed lol :) I tried with OpenMP. In the build.py I added a setting (while it would have been better to check if openmp is present). I will check if it passes CI. If you are interested on an interesting problem is to try to understand why the project a friend of mine made is slow with my CEF and keyboard broken https://www.exaequos.com/ (while the secondary process works well)