Lecrapouille / gdcef

[Plugin][Version 0.10.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4
https://discord.gg/EckEwy7S5U
MIT License
222 stars 26 forks source link

Not able to get jitsi-meet works in the 2D demo #49

Closed GeorgeS2019 closed 5 months ago

GeorgeS2019 commented 5 months ago

Wonder what is missing?

Lecrapouille commented 5 months ago

@GeorgeS2019 without context, difficult to tell you. I know ffmpeg hd264 is not given by default in CEF prebuilds. I know my plugin is suffering with page using massive webasm code such as https://www.exaequos.com/

GeorgeS2019 commented 5 months ago

For jitsi-meet to work, it request permission to microphone and video.
In the 2D demo, no such request.

GeorgeS2019 commented 5 months ago

For a folder with index.html and the javascript to be loaded, will the javascript be loaded?

Lecrapouille commented 5 months ago

@GeorgeS2019 Ok i reproduce it. Probably correlated with https://github.com/Lecrapouille/gdcef/issues/19. No I also reproduce it with cefsimple: the basic web browser given as example with CEF prebuilt. Maybe you can try to open a ticket to https://magpcss.org/ceforum/index.php For the second question: no. https://github.com/Lecrapouille/gdcef/issues/40

GeorgeS2019 commented 5 months ago

@Lecrapouille What if the javascript is embeded within the html ?

Lecrapouille commented 5 months ago

@GeorgeS2019 JS inside html is working. My demos uses pages with three.js (3D). Punto one of the Godot creator asked to implement JS wrappers (but I did not had time). Else concerning your initial issue. I saw in my logs CEF is checking for my devices but as mentioned we have to give some permissions: https://www.magpcss.org/ceforum/viewtopic.php?f=6&t=14969 I'll see how to add it

GeorgeS2019 commented 5 months ago

@Lecrapouille Thx for making so much progress with the Godot4 CEF browser.

Lecrapouille commented 5 months ago

I see what I have to write but the callback is not triggered. I'm not sure if I placed it correctly

GeorgeS2019 commented 5 months ago

thx for trying. Imagine Jitsi is possible in Godot4. It will be game chaning.

Unity already has Jitsi. Just google it.

Lecrapouille commented 5 months ago

@GeorgeS2019 Ok I finally succeeded to make it works. Since tonight I'll be in hollidays without access to my personal computer I'll make a quick patch and will rework if later.

Lecrapouille commented 5 months ago

@GeorgeS2019 Note you need to comment the _on_page_failed_loading I dunno why some pages entered on this callback including jitsi

GeorgeS2019 commented 5 months ago

there is no windows artifact. I wait

Lecrapouille commented 5 months ago

@GeorgeS2019 I'm not sure to understand what you said. I did not start a meeting (since I had no friends to call lol) but I saw my webcam was working at least on Linux. You can update your project from this repo (the change is not yet available on Godot asset store) and try the demo2D I added the new settings to allow using camera and microphones.

https://github.com/Lecrapouille/gdcef/blob/a47b4b9f11ec7c763e134affc58c88b18a8ec3bb/addons/gdcef/demos/2D/CEF.gd#L296

GeorgeS2019 commented 5 months ago

It is not trivial build, so I wait

Lecrapouille commented 5 months ago

@GeorgeS2019 Ok I can tag 0.8.1 or 0.9.0 the CI will create artifacts https://github.com/Lecrapouille/gdcef/releases

Lecrapouille commented 5 months ago

CI is running will be 0.9.0-godot4

GeorgeS2019 commented 5 months ago

Sorry for making your holiday short

GeorgeS2019 commented 5 months ago

I went to nap. It works in 2D, thank you