Lecrapouille / gdcef

[Plugin][Version 0.13.0][Functional] Chromium Embedded Framework Webview for Godot 3 and 4
https://discord.gg/EckEwy7S5U
MIT License
268 stars 31 forks source link

Wrong folder organisation #8

Closed Lecrapouille closed 2 years ago

Lecrapouille commented 2 years ago

@raphipod This project is now on the Godot asset lib https://godotengine.org/asset-library/asset/1426 I tagged it as 2D tools but I just realized that I should have placed all contents inside a addons/gdcef folder. Since i'm noob in Godot, raphipod can you confirm ?

raphipod commented 2 years ago

Confirmed. It dumps all gdcef files in the project root instead of in /addons/gdcef, as you said.

AFAIK this shouldn't be a problem - Godot just wants it's .godot file and doesn't care. It certainly would look nicer if the addon would be in it's own addons folder, though.

MGilleronFJ commented 2 years ago

It would be cleaner if all necessary files were undert addons/gdcef and nothing else. Also, you have other files around which users have to check/uncheck before installing the plugin. I suggest you add a .gitattributes to your repo to exclude these files so when the assetlib downloads your plugin Github will make a zip package containing only what's necessary. See https://github.com/Zylann/godot_heightmap_plugin/blob/master/.gitattributes

Lecrapouille commented 2 years ago

@MGilleronFJ thank you ! Nice to have confirmation ! I'll do it after my holidays in a couple of days ! I also find this project with the same folders organization: https://github.com/gilzoide/godot-lua-pluginscript and they relase to this repo https://github.com/gilzoide/godot-lua-pluginscript-distribution for the asset store. But I find it more complex.

Lecrapouille commented 2 years ago

@MGilleronFJ since I cannot currently test on Linux I made a commit on the dev-refacto branch. Does this seem fine for you ?

Lecrapouille commented 2 years ago

Merged to master. I'll clean the doc and upload again on the store. Feel free to open a new ticket.