LedgerHQ / app-passwords

Password Manager application for Ledger devices
Apache License 2.0
82 stars 22 forks source link

Warn user about password loss during OS /app upgrade #52

Open lpascal-ledger opened 1 year ago

lpascal-ledger commented 1 year ago

As there are no storage resisting OS and application upgrade, currently all passwords are lost when a user upgrade it OS or the password application. A tool exists to backup / restore them, however we should strongly highlight this, like with a disclaimer message the first time the app is started (?).

aido commented 1 year ago

Another good reason to change the app to use the BIP85 standard to generate passwords? 😄

48

TheWanderer1983 commented 12 months ago

You really should do this. I've been using the ledger for a number of years now and I use the password app for my login for my computer. I was forced into upgrading the firmware in order to continue restaking my polygon and cosmos. I upgraded it and lost all my passwords. I had used the tool to backup the json a year or so ago but I couldn't remember where I put it. I use these to login to my LUKS encrypted computer. Thankfully I was able to remember the name to regenerate the computer password but it took me over 20 attempts and all day before I did.
How about a warning before you upgrade the firmware about the password app losing passwords?

lpascal-ledger commented 11 months ago

There are some work invested in a client-side (Ledger Live) solution, which is quite larger than just a warning as the root issue is how to keep all app 'local storage' persistent across upgrades (because this issue is basically the same thing as settings being reset). But when embracing the whole system, just a warning feels a small gain for a not so trivial change (or we could argue it already exists in a very simple form, as I'm pretty sure the Ledger Live pops up a "save your data" warning before an upgrade). But until this is fixed by system/OS design, I'd think an app disclaimer clarifying the current behavior could be an easy and not that costly step.