Closed eslerm closed 1 year ago
please squash :)
Thanks! This would be so much easier if we just used Docker from Ubuntu repos...
This would be so much easier if we just used Docker from Ubuntu repos...
After a new Ubuntu Release starts, most packages in the previous release are version locked and only receive security updates except for extraordinary circumstances. That's why Docker suggests using their repos. Using the docker snap could fit the same need though.
With this merge, the Docker repos are now only added when: ansible_distribution == 'Ubuntu'
. Please be aware that Debian and other distros need explicit support now (the merge removed implicit support using incorrect configs).
lemmy-ansible uses deprecated
apt-key
and Docker's apt repo is only configured for Ubuntu 20.04 (Focal) binaries.To reproduce run lemmy-ansible on an Ubuntu 22.04 (Jammy) vm. Login and check apt configuration:
This commit makes apt configuration conditional on release number. The pre-Jammy configurations were left as is. Jammy++ configs adapt to ansible_distribution_release (i.e., jammy, kinetic, lunar, and mantic get the correct binaries) and use the
signed-by
apt config, which replacesapt-key
and is suggested by Docker. I did not dearmor the key as Docker suggested for Ansible convinence. Please verify the checksum. The README.me says that Debian-based vms are supported, but that's was not the case for Docker binaries before or with this commit.I tested the patch on Focal, Jammy, and Lunar. Focal and Lunar failed after apt config unrelated preexisting issues (https://github.com/LemmyNet/lemmy-ansible/issues/54 in the case of Lunar). This fixes https://github.com/LemmyNet/lemmy-ansible/issues/61 and partially resolves https://github.com/LemmyNet/lemmy-ansible/issues/82