Closed ticoombs closed 5 months ago
It'd also be nice if there were lemmy-ansible / docker specific 0.4 -> 0.5 upgrade instructions on the readme.
@dessalines That's why it's still in a draft state ;)
@asonix Could you possibly give some lemmy-specific pictrs v0.4-v0.5 upgrade instructions?
I see this upgrade guide: https://git.asonix.dog/asonix/pict-rs/#0-4-to-0-5-migration-guide
But it doesn't say how to perform it offline, or for docker. @Nutomic is also saying that an intermediate step was necessary to go to 0.4.7
first, then to 0.5
. We need these upgrade instructions fully detailed, ideally with little downtime. Apparently there is a prepare_upgrade
method?
you can either run 0.4.7 and then call POST /internal/prepare_upgrade its documented here: https://git.asonix.dog/asonix/pict-rs/src/tag/v0.4.7 or go directly to 0.5 without preparing, then the db migration will be performed on first start which means a bit of downtime
you can either run 0.4.7 and then call POST /internal/prepare_upgrade
Which we have already done as part of 1.3.1 and I am going to assume everyone that uses the ansible repo has done.
The only items to really check are for the new 0.5 environment variables, and provide those correct variables under example vars, and possibly a check (testing on our side) to confirm if wrong variables in the pictrs docker will block it from starting.
Config changes are documented here: https://git.asonix.dog/asonix/pict-rs/#user-content-configuration-updates
Will wait for @Nutomic / @dessalines to also Approve before merging after reading: https://github.com/LemmyNet/lemmy-ansible/pull/213/commits/1c33460ffcd6f88191692ce0ccec057f96712a0a
Looks good to me.
:rocket: Merging
Closes: #215 #208