LemmyNet / lemmy-ansible

A docker deploy for ansible
GNU Affero General Public License v3.0
248 stars 92 forks source link

Add missing ansible tags #236

Closed sanatsathaye closed 5 months ago

sanatsathaye commented 6 months ago

Added tags to lemmy.yml and lemmy-almalinux.yml. Hope they look fine, pls suggest if there's any that can be changed.

Also, this will kinda sorta help with #189 because you can run something like ansible-playbook lemmy.yml --skip-tags ssl that will effectively bypass everything related to ssl in case you want to reuse existing certificates (or your setup is like mine where I test out the files within WSL/vagrant without a valid domain).

Honestly speaking I wouldn't recommend running the playbook solely relying on tags at all unless you're extremely familiar with both the playbook and ansible, but it can be used for cases like I mentioned.

I don't think uninstall.yml needs tags because it completely works on user input so I didn't bother.

sanatsathaye commented 6 months ago

@codyro did most of the work with tags already in the Alma playbook, so I've re-used as much as I can 😄

ticoombs commented 6 months ago

Is there a reason we've gone so descriptive with these? ie; can you let us know how we'd want to use them?

If we have these tags we should also have some documentation on how to use them efficiently. Otherwise I can see people running into problems.

I understand ssl/certbot/initial as users could skip that and that could help solve #189 but i'm not sure of the others.

(We'll most likely accept it as it is, but if we can have some guidance on how we could utilise these tags that would be great)

codyro commented 6 months ago

Is there a reason we've gone so descriptive with these? ie; can you let us know how we'd want to use them?

  • --skip-tags directories (to speed up?)

  • --tags always --tags docker (to install docker?)

  • --skip-tags dependencies (speed up?)

If we have these tags we should also have some documentation on how to use them efficiently. Otherwise I can see people running into problems.

I understand ssl/certbot/initial as users could skip that and that could help solve #189 but i'm not sure of the others.

(We'll most likely accept it as it is, but if we can have some guidance on how we could utilise these tags that would be great)

Regarding the playbook I made, I tend to do it for development reasons (which sometimes can be helpful in production). I don't think it's harmful to have, though.

I used the always tag because it's a special use one: https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_tags.html#special-tags-always-and-never

It lets you ensure some tasks always run even when limiting them to a subset via --tags, providing mission critical tasks run regardless of what's passed. I assume that’s what @sanatsathaye using as an example/baseline.

dessalines commented 6 months ago

I'll defer to @codyro 's recommendations on this one, but simpler is better.