Closed jlandahl closed 2 months ago
Sure, a PR would be much appreciated, esp since they deprecated that plugin.
@ticoombs has already been working on this in #237, but it might make sense to split the compose v2 change from the other changes, as this seems more urgent?
I submitted PR https://github.com/LemmyNet/lemmy-ansible/pull/240. I just looked at https://github.com/LemmyNet/lemmy-ansible/pull/237 and see that it already changed to docker_compose_v2
, but it still has the setting pull: true
. That won't work anymore since the setting has been changed from a boolean to a string.
I just setup a new Lemmy site the other day following all the instructions in the readme and hit a snag at the docker-compose step. There was an issue with the Ansible
community.docker
collection relating to a newer version ofurllib3
(https://github.com/docker/docker-py/issues/3113) that has since been fixed.But after quite a lot of digging and trial and error, I discovered that the
community.docker.docker_compose
action (used here) has been deprecated in favor ofcommunity.docker.docker_compose_v2
, and it looks like the bug may have only been fixed in the_v2
version. That's my conclusion, at least, since I was able to get the playbook to work by switching to thev2
action.Here's the diff that got me up and running:
The change to the
pull
setting was required becausev2
now takes a string from a list of options rather than a boolean.I'll be happy to submit a PR for this, but I thought I'd document it here first since I don't know if this has been encountered by anyone else yet.
Updated to add: this was on a brand new VM running Ubuntu 24.04 with Python 3.12, so that could be where the problems cropped up.