Feat es lint - Githubissues

LetsGetTechnical / gridiron-survivor

https://gridiron-survivor-letsgettechnical.vercel.app

4 stars 1 forks source link

Feat es lint #123

Closed chris-nowicki closed 1 month ago

chris-nowicki commented 1 month ago

Fixes #66 - adds the ability to lint our project using eslint

Setup & Run

There are two new lint dev dependency packages: eslint-config-next & eslint-plugin-jsx-a11y so be sure to install them by running pnpm i
Type npm run lint to lint the project

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gridiron-survivor	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 15, 2024 5:19pm
gridiron-survivor-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 15, 2024 5:19pm

shashilo commented 1 month ago

I want to ensure we have NO WARNINGS. Any rule we set up is an ERROR. This will stop devs from ignoring warnings.

chris-nowicki commented 1 month ago

I want to ensure we have NO WARNINGS. Any rule we set up is an ERROR. This will stop devs from ignoring warnings.

Agreed. I think there are some default ones we may be able to suppress but right now you have to do it rule by rule in the config file. I am not finding anything that turns off global warnings.

There is a quiet option that I added into the package.json script that is supposed to show only errors when run:

"scripts": {
        ...
        "lint": "next lint --quiet"
    }