Closed ryandotfurrer closed 3 weeks ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
gridiron-survivor | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 25, 2024 1:47am |
gridiron-survivor-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 25, 2024 1:47am |
Everything looks good to me! Although you should look into the PR failing the Vercel check.
Buh, it was still running when I last checked and didn't see it failed. I'll have to look into why.
@ryandotfurrer
I'm very new to Next and shadcn, and in general working with component libraries, but this looks good to me.
@ryandotfurrer please adjust the Storybook story to reflect and show these variants as well. This is the way @jasinn will review design implementation. Also, add unit test for these components to ensure the variants are showing the correct styles. We should look into adding visual tests with Storybook 8 as well.
@ryandotfurrer please adjust the Storybook story to reflect and show these variants as well. This is the way @jasinn will review design implementation. Also, add unit test for these components to ensure the variants are showing the correct styles. We should look into adding visual tests with Storybook 8 as well.
I will make these updates (and your above-mentioned ones) by EoD 4/16/24.
@ryandotfurrer please adjust the Storybook story to reflect and show these variants as well. This is the way @jasinn will review design implementation. Also, add unit test for these components to ensure the variants are showing the correct styles. We should look into adding visual tests with Storybook 8 as well.
@ryandotfurrer please adjust the Storybook story to reflect and show these variants as well. This is the way @jasinn will review design implementation. Also, add unit test for these components to ensure the variants are showing the correct styles. We should look into adding visual tests with Storybook 8 as well.
I will make these updates (and your above-mentioned ones) by EoD 4/16/24.
@shashilo Please re-review when you get a chance. I need to get to bed but will work on the following tomorrow during lunch and after work:
I was able to run pnpm run build
locally without a problem, not sure why I am getting errors with Vercel when I push...
Closes issue #124
Change Description(s)
-Edited Button component to customize to our colors
Finished Results
Below is a screenshot of their buttons. I placed them inside a div with a border and some padding so you could see that they are the full-width of the parent container (minus the padding).