LetsGetTechnical / gridiron-survivor

https://gridiron-survivor-letsgettechnical.vercel.app

4 stars 1 forks source link

Create nav component #158

Closed ryandotfurrer closed 2 weeks ago

ryandotfurrer commented 3 weeks ago

Closes #155

Created nav component

Screenshot of Nav component in dark mode

https://github.com/LetsGetTechnical/gridiron-survivor/assets/40150036/0e143fbb-a8f7-45b9-9465-0983c3dfbc10

Todo

[x] Add hamburger icon ~~- [ ] Add logic to show sign out only if user is signed in (?)~~ Not needed for MVP
[x] Integrate Button.tsx component from #132 and use in place of standard <button> element

appwrite[bot] commented 3 weeks ago

Gridiron Survivor Application 6616ea581ef9f5521c7d

Function	ID	Status	Action

Your function deployment has failed. Please check the logs for more details and retry.

Project name: Gridiron Survivor Application Project ID: 6616ea581ef9f5521c7d

Function	ID	Status	Action
userAuth	`6626fef885a9f630442b`	Failed	View Logs

Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.

💡 Did you know? Appwrite has a Discord community with over 16 000 members. Come join us!

vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gridiron-survivor	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2024 0:49am
gridiron-survivor-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 30, 2024 0:49am

ryandotfurrer commented 2 weeks ago

Separate Logo Component vs Part of Nav Component

@emestabillo

I think the logo should be part of the nav component instead of a standalone since it's not reused anywhere else. But I'll defer to ~~@shashilo~~

In that vein, you could argue that NavDrawer.tsx doesn't have to be it's own component either. I tend to build with Atomic Design in mind; breaking components up as much as possible. I too am curious to hear what @shashilo thinks!

View Stories Located Outside of `stories/components`

@emestabillo

Also, how do I view stories located outside of the stories/components folder?

That is great question and I was wondering that myself. Perhaps the Storybook config has to be pointed to look elsewhere? Paging @choir27