search

LiamWellacott / CDT2019-ERL

1 stars 6 forks source link

Object detection update #81

Closed kini5gowda closed 3 years ago

kini5gowda commented 3 years ago

Getting bugs with respect to depth camera. The rest works perfectly fine. I have commented out the 2d to 3d part. Will have to figure out the depth camera part.

LiamWellacott commented 3 years ago

@kini5gowda if this depends on your previous PR I will wait for that to go through before reviewing, see my comment on that about merging.

kini5gowda commented 3 years ago

Nope, doesnt depend on the previous one. I've removed the previous pull request and started a new one.

On Tue, 2 Mar 2021, 15:45 Liam Wellacott, notifications@github.com wrote:

@kini5gowda https://github.com/kini5gowda if this depends on your previous PR I will wait for that to go through before reviewing, see my comment on that about merging.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/LiamWellacott/CDT2019-ERL/pull/81#issuecomment-788793929, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGI72AZ5OS5NYTUV7PN4CZLTBS3FFANCNFSM4YM7XUSA .

LiamWellacott commented 3 years ago

please merge with my main then I will review this.

LiamWellacott commented 3 years ago

After chatting to Pierre this is not ready to come back to main, the dockerfile command doesn't work currently and apparently there is outstanding work to get DOPE working. We will reopen when the code is ready.