Closed deependujha closed 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
main@f2c5a7b
). Learn more about missing BASE report.
Hey @deependujha. Can you describe which bugs this is fixing ?
Hey @deependujha. Can you describe which bugs this is fixing ?
Sorry for the delay in response. I've updated the description. Plz have a look at it. It's an extension of a PR that has been merged already (#187 )
Before submitting
- [ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/lit-data/blob/main/.github/CONTRIBUTING.md), Pull Request section? - [ ] Did you make sure to update the docs? - [ ] Did you write any new necessary tests?What does this PR do?
train_test_split works perfectly when asked to split dataset in splits=[0.1, 0.7, 0.2], but it fails when asked for splits=[0.1, 0.2, 0.7].
In the original code, this code will fail:
Except the failure, if you look at the values printed by
y[:]
, it overlaps withx[:]
. This was bcoz of the way reader was reading from chunks.Code for
output_dir
These bugs have been fixed in this PR. This PR originally aimed at closing a issue #186 , but it has been closed already, bcoz of some confusion.
PR review
Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃