Lightning-AI / pytorch-lightning

Pretrain, finetune and deploy AI models on multiple GPUs, TPUs with zero code changes.
https://lightning.ai
Apache License 2.0
27.98k stars 3.35k forks source link

Update PL ecosystem libraries to the stable Accelerator/Strategy API #12026

Closed awaelchli closed 1 year ago

awaelchli commented 2 years ago

Proposed refactor

Create an issue and send a PR to repositories that depend on the outdated "TrainingTypePlugin" API and update them to the stable Accelerator/Strategy API.

Motivation

As we are releasing an updated, stable API for Strategy (formerly known as TrainingTypePlugin) with Lightning 1.6 we want to ensure that we notify and support the community about the changes. A smooth transition will ensure that early adopters can profit from the improvements the new API brings. Since the API in some strategies has changed dramatically, we can offer some help.

Candidates

Additional context

9932 #10416


If you enjoy Lightning, check out our other projects! ⚡

cc @justusschock @awaelchli @rohitgr7 @akihironitta

Borda commented 2 years ago

I think it is related to EcoCI feature request: https://github.com/PyTorchLightning/ecosystem-ci/issues/24

ChickenTarm commented 1 year ago

Hi, is this still being worked on?

Borda commented 1 year ago

Hi, is this still being worked on?

Would you be interested in helping us? :rabbit:

ChickenTarm commented 1 year ago

Sure I can give it a shot. Is there a good source to start with for this: what are the required aspects of a strategy, changes made between 1.6 and 1.7+ for the strategy api, etc?

awaelchli commented 1 year ago

@ChickenTarm This is an old ticket that I created a year ago and it got forgotten, sorry! The main motivation was to update the apis used over in ray lightning. There are some overrides for Accelerator, Launcher, and Strategy here: https://github.com/ray-project/ray_lightning/tree/main/ray_lightning These would have to be updated with the latest imports and apis, but the work would be done completely outside Lightning in this repo.