Lightning-AI / pytorch-lightning

Pretrain, finetune ANY AI model of ANY size on multiple GPUs, TPUs with zero code changes.
https://lightning.ai
Apache License 2.0
28.22k stars 3.38k forks source link

MPS AMP Support #14358

Open justusschock opened 2 years ago

justusschock commented 2 years ago

🚀 Feature

After https://github.com/pytorch/pytorch/issues/78168 was apparently resolved on pytorch master/nightlies we should re-evaluate fp16/amp support for mps devices.

cc @borda @carmocca @justusschock @awaelchli @akihironitta @rohitgr7

carmocca commented 2 years ago

What exactly do you mean with re-evaluate? Are there any changes necessary in the code? Did we add any warnings or errors for this configuration?

justusschock commented 2 years ago

This is currently blocked by errors and we do need to check whether this fix actually works :)

justusschock commented 1 year ago

Blocked by https://github.com/pytorch/pytorch/issues/88415