Lionstein / ecommerce-pattern-library

A term-long project redesigning an ecommerce website focusing on making a pattern library.
https://awesome-northcutt-07dcc5.netlify.com/
0 stars 0 forks source link

Final Grade : Late submit because I can't read :V #10

Open Lionstein opened 4 years ago

Lionstein commented 4 years ago

Sorry about this late submit, I looked under the "finalizing pattern library" part and totally missed the request for grade. Understandable if its too late for the grade now, but here it is:

Style & Design: 3 points, I managed to stick very closely to my original concept mockup, and all the pages match.

Patterns: 2 points, I did only make templates for the template pages.

Explanations: 1 point, I think they'd be hard to understand for someone who doesn't know how I've organized the website.

Accessibility: 1 point, Not all accessibility works and its quite limited.

Semantics: 2 points, All HTML tags are named after what they do or correspond to the specific product.

Responsiveness: 1.5 points? It works on all screens, but the nav is a little wonky and there are some carousel issues that I couldn't figure out how to fix. (invisible 5th slide and paused rotation)

Code Quality: 1 point, I'm missing much accessibility, but semantics are pretty good.

Git & Commits: 1 point, Commit names weren't very descriptive and sometimes reflected general panic.

12.5/24 - 50.5%

@thomasjbradley