v1.3.0 - Githubissues

Living-with-machines / DeezyMatch

A Flexible Deep Learning Approach to Fuzzy String Matching

Other

139 stars 34 forks source link

Closed kasra-hosseini closed 2 years ago

kasra-hosseini commented 2 years ago

FIX the issue with n-grams (see https://github.com/Living-with-machines/DeezyMatch/issues/109)
To generate vectors, we don't need three-column inputs anymore. We can have one column (or three columns for backward compatibility)
normalizeString and string_split functions are reviewed
Several tests are added

TODO:

review-notebook-app[bot] commented 2 years ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

kasra-hosseini commented 2 years ago

@mcollardanuy Is there anything else that we should consider in this PR?

mcollardanuy commented 2 years ago

Hey @kasra-hosseini, all changes look good! Please feel free to go ahead and merge, thanks!