Select the device in candidateFinder, torch.load and faiss need to be changed.

Living-with-machines / DeezyMatch

A Flexible Deep Learning Approach to Fuzzy String Matching

https://living-with-machines.github.io/DeezyMatch/

Other

139 stars 34 forks source link

Select the device in candidateFinder, torch.load and faiss need to be changed. #28

Closed kasra-hosseini closed 4 years ago

mcollardanuy commented 4 years ago

I think it would be good to add the possibility to specify the device from a command-line argument in each python script, to make it easier for the user to select the device. Does that sound good @kasra-hosseini?

kasra-hosseini commented 4 years ago

This should be addressed in https://github.com/Living-with-machines/DeezyMatch/pull/39/commits/f88ec94a5aac8a647078a215ce91c1dfe9b244fb and https://github.com/Living-with-machines/DeezyMatch/pull/39/commits/c08e6ce11f19b881dbe42851ba6c4e7f269aaf00. The device specified in the input is used in both combineVecs and candidateFinder. Faiss still uses CPU (refer to issue #43 ).