search

Living-with-machines / DeezyMatch

A Flexible Deep Learning Approach to Fuzzy String Matching
https://living-with-machines.github.io/DeezyMatch/
Other
139 stars 34 forks source link

Feature/33 implement map #42

Closed fedenanni closed 4 years ago

fedenanni commented 4 years ago

@kasra-hosseini changes in data_processing were already there, I havent made them this morning. There's a couple of commands that are repeated - if it's just noise I'll remove them but I wanted to doublecheck.

@mcollardanuy It's still a draft, there might be issues that I don't see without testing it with real datasets

kasra-hosseini commented 4 years ago

@fedenanni Many thanks for this PR. I made some inline comments. Please let me know if something is not clear.

kasra-hosseini commented 4 years ago

@fedenanni I changed the log_plotter and it seems that we now have some conflicts. Could you please update this? I am also happy to do that.

kasra-hosseini commented 4 years ago

@fedenanni Thanks Fede for the changes and the PR.