Feature/51 pypi - Githubissues

Living-with-machines / DeezyMatch

A Flexible Deep Learning Approach to Fuzzy String Matching

https://living-with-machines.github.io/DeezyMatch/

Other

139 stars 34 forks source link

Feature/51 pypi #52

Closed kasra-hosseini closed 4 years ago

kasra-hosseini commented 4 years ago

[WIP]

[x] Package DeezyMatch
[x] Update README
[x] Reviewers' confirmation: @mcollardanuy @fedenanni
[x] Upload on Pypi

kasra-hosseini commented 4 years ago

@mcollardanuy and @fedenanni I am done with this PR. Let me know if you have any comments.

kasra-hosseini commented 4 years ago

@mcollardanuy and @fedenanni as discussed, I renamed finder with ranker in all codes (hopefully!), would you please test these and let me know if you have any comments? (no rush)

Here is the commit: https://github.com/Living-with-machines/DeezyMatch/pull/52/commits/1780b8562cef53cd4bb5ecfe60490d345a29b35f

mcollardanuy commented 4 years ago

Hi @kasra-hosseini I'm done for now, it looks really good! I've left some comments, I can have another look to the changes later.

kasra-hosseini commented 4 years ago

In addition to not-resolved items above:

[x] issue with log plotter (it seems that it skips the first epoch in some examples)

This should be solved now in https://github.com/Living-with-machines/DeezyMatch/pull/52/commits/1a47bc05ad735b983a8c0871de5646c14233c318