search

Living-with-machines / DeezyMatch

A Flexible Deep Learning Approach to Fuzzy String Matching
https://living-with-machines.github.io/DeezyMatch/
Other
139 stars 34 forks source link

Results used in Fig2 of EMNLP paper #77

Closed kasra-hosseini closed 4 years ago

kasra-hosseini commented 4 years ago

This notebook contains all the results used in Fig2 of the EMNLP paper.

kasra-hosseini commented 4 years ago

@fedenanni Could you please take a look at these notebooks whenever you have time?

fedenanni commented 4 years ago

Hi! I am reviewing it now using ReviewNB. Tiny thing that I noticed so far, instead of having this located inside "examples", maybe I will have it in a different folder (maybe figs/paper_figures/) - but really as you prefer

kasra-hosseini commented 4 years ago

@fedenanni Thank you for the review and sorry for the delay. I moved the notebooks to this directory: figs/EMNLP2020_figures/fig2. Also, added the inputs there and updated the README accordingly.

kasra-hosseini commented 4 years ago

Also added some info about the models to the notebooks: https://github.com/Living-with-machines/DeezyMatch/pull/77/commits/cfdcb581fd98cce02271ab0e76dcc5cec9a78358

kasra-hosseini commented 4 years ago

@fedenanni If you are happy with the changes, I will go ahead and merge?

fedenanni commented 4 years ago

@kasra-hosseini ah great with the added infos on the model - yes go ahead and merge it, thanks!