search

Living-with-machines / DeezyMatch

A Flexible Deep Learning Approach to Fuzzy String Matching
https://living-with-machines.github.io/DeezyMatch/
Other
139 stars 34 forks source link

Feature/2 candidate finder #9

Closed kasra-hosseini closed 4 years ago

kasra-hosseini commented 4 years ago

@kasra-hosseini hi! So, I went through it! As I mentioned on Slack, I commented the parts of the code I know (mostly tiny things) and then checked the new scripts. Maybe, when we have candidate_finder in an almost final shape we could go through it together, to be sure that all is consistent

Thanks! Sounds very good.

kasra-hosseini commented 4 years ago

@fedenanni Many thanks for the comments. I went through them and tried to answer the questions. I also made some new issues for the next PR. One remaining task from my side is to update the READMEs. I will do this today and report back here.

fedenanni commented 4 years ago

@kasra-hosseini ok! I am merging the PR and then we update together the README while in the develop branch, see you there!