Check lines 328-331 in candidateRanker.py (see here). Comment and code are not aligned: according to the comment, 0.99 is multiplied, but in the code it's 1.01. Change the comment accordingly:
elif ranking_metric.lower() in ["cosine"]:
# 0.99 is multiplied to avoid issues with float numbers and rounding errors
if query_candidate_pd["cosine_dist"].max() > (selection_threshold*1.01):
break
kasra-hosseini
commented
2 years ago
Check lines 328-331 in
candidateRanker.py(see here). Comment and code are not aligned: according to the comment, 0.99 is multiplied, but in the code it's 1.01. Change the comment accordingly: