search

Living-with-machines / DeezyMatch

A Flexible Deep Learning Approach to Fuzzy String Matching
https://living-with-machines.github.io/DeezyMatch/
Other
134 stars 34 forks source link

Fix the hardcoded multiplier in candidateRanker #98

Closed kasra-hosseini closed 2 years ago

kasra-hosseini commented 3 years ago

In candidateRanker lines 326 and 330, there is a hardcoded multiplier 1.01 to "avoid issues with float numbers and rounding errors". Is it possible to find a better way for this, e.g., numpy.isclose?

kasra-hosseini commented 2 years ago

Done: https://github.com/Living-with-machines/DeezyMatch/pull/121