Fixes to looping interaction with the riff repeater

tjwrona commented 2 years ago

Cleaned up looping logic more and made it play more friendly with the riff repeater.

Validation of loopStart and loopEnd is done when they are initially set so it doesn't need to be checked again.
Loop counter is ignored in the riff repeater (riff repeater functions normally even with a loop enabled)

There is still one very tricky bug I have not been able to resolve. When pressing "resume" from the riff repeater menu when you have a riff repeater section outside of the loop selected it does not properly seek back to the start of the loop and some notes can appear greyed out. Simply pausing and then resuming again (with ESC) resolves the bug but I would like to get this to be automatic.

ffio1 commented 2 years ago

Merging with intent to modify.

ffio1 commented 2 years ago

Modifications present in: https://github.com/Lovrom8/RSMods/commit/a3343599303964b2bb2f65b8158e2743d13f7944

Changes include:

Adding a check for RR menus, and resetting the loop if the user enters them.
Adjusted some comments to better reflect the code that is being ran.

As always, thanks for this PR!

Lovrom8 / RSMods

Fixes to looping interaction with the riff repeater #108