search

Lovrom8 / RSMods

383 stars 34 forks source link

Revert commits that caused crash #116

Closed tjwrona closed 2 years ago

tjwrona commented 2 years ago

@ffio1 please take a look at why these commits caused a crash and then reimplement them if you can find the problem. Oddly it seemed to run without crashing in debug builds, but these changes were causing the game to crash instantly on startup in release builds.

ffio1 commented 2 years ago

This was caused by the new logging macros. I made some changes to the macros for how they should work in RELEASE builds vs DEBUG builds (mainly to remove the added dependency of the DEV log that goes unused), and to add some error checking through a try-catch block that will log the message directly to cerr if it can't be done through the log macro.