Lovrom8 / RSMods

372 stars 34 forks source link

Toggle Song Preview? #160

Open HeroMagnus opened 1 year ago

HeroMagnus commented 1 year ago

Is there a way to Toggle Song Preview? I'd say 75% of the time I personally do not want song previews BUT would like them on occasion, Any workaround maybe or another way to do so? Thx

ffio1 commented 1 year ago

There's a mod for that. In the "Enable / Disable Mods" tab, check the "Remove Previews" box.

HeroMagnus commented 1 year ago

To toggle it while in game?

ffio1 commented 1 year ago

Yeah I think that's one of the mods we allow you to change while the game is open.

HeroMagnus commented 1 year ago

can it be hotkeyed?

ffio1 commented 1 year ago

No, it cannot.

HeroMagnus commented 1 year ago

be a nice feature i guess but thx my next plan was to test if it could be enabled/disabled with the game open

HeroMagnus commented 1 year ago

could it be hotkeyed if it was coded? or is it just a no go? sorry i dont know about programming stuff like this

ffio1 commented 1 year ago

If it was coded, it could be hotkeyed. But it's not programmed like that right now.

The original reason we added the mod, if I recall correctly, is that a twitch streamer didn't want previews playing so we built it for their usecase.

HeroMagnus commented 1 year ago

thats pretty much my case i dont need it for alot of songs i know but when i get a request that i think is sus id like to take a quick listen and go from there. More of an insurance policy i guess, so its not a waste of my time or mean skill check

kozaka-tv commented 1 year ago

If it was coded, it could be hotkeyed. But it's not programmed like that right now.

The original reason we added the mod, if I recall correctly, is that a twitch streamer didn't want previews playing so we built it for their usecase.

And I think (but I am a bit unsure), during the preview, RockSniffer reads all the stuff out what he need to provide information about the song will be played. Idk, that this is true or not, but I remember so. That I turned it off, and then something was not worked....maybe it was tuning? Idk :)

ffio1 commented 1 year ago

It did at first but I submitted a PR to the rocksniffer code and Koko merged it in a while ago.

HeroMagnus commented 1 year ago

For a workaround you can open RSMods and toggle Preview on/off, you just have to back out to Main Menu(from what I've tested, it works everytime). With a hotkey it'd be a nice feature for me cuz it would eliminate having to click into RSMods when i have all 4 of my screens full of windows. But not a huge deal either, Thx for your time!

kozaka-tv commented 1 year ago

It did at first but I submitted a PR to the rocksniffer code and Koko merged it in a while ago.

Oh, nice! Then I could also turn the preview off :)

To have a hotkey in RSMods for this, would be also a good feature.