search

Lovrom8 / RSMods

393 stars 38 forks source link

Feature Request : control volume instrument #51

Closed NicolasMuzette closed 3 years ago

NicolasMuzette commented 4 years ago

If you can control the song volume, can you control the instrument volume ?

The idea would be to be able to control the volume of the played instrument without breaking the notes detection, so you can replace on the fly a crappy the rocksmith instrument sound with one on your own (VST / Pedalboard / ...) while streaming.

Idealy, the toggle would be done with a programmable midi control.

Thanks for the good work

ffio1 commented 4 years ago

We have a way to control the volume of the song / instrument inside the mod already. You need to set "Control Volume" in the Checkboxes (probably not the full name), and then set an add volume key, a decrease volume key, and a change selected volume key.

When in game, click the change selected volume key, and the menu should pop up. If you press it once, it should change to Song Volume from Master Volume, if you press it again it should go to Player 1 Volume. This is where you should increase or decrease the volume using the add / decrease volume keys. If you want the text to stop being drawn at the top of the screen, just press the change selected volume a couple more times. Repeat if you need to change it later.

For "not breaking note detection", I don't believe our current system does that. The only case where we do that is where we forget we are running a loop and hogging a thread which I believe we fixed (hopefully). The current implementation is like 6 lines of non-looped code that sends code straight to the backend of the Mixer screen so it shouldn't break note detection. If you have a video or something of it happening, I'd be glad to take a look at it but from all the time I personally spent messing with the audio engine in game, it's never locked up note detection.

NicolasMuzette commented 4 years ago

Oh thanks i'll try that tonight i guess :)