Lovrom8 / RSMods

393 stars 37 forks source link

DLL - Bug - Extended Range mode only works in tuner #71

Open MAR-VlN opened 3 years ago

MAR-VlN commented 3 years ago

Fantastic work on this mod suite, works really well, except...

I bought a 7 string guitar recently and enabled the ER mode after installing the latest release.

It seems to work in the tuner, so the string colours are as per the ER selection, but as soon as the song loads in the colours revert to the standard set. I decided it was obviously something I was doing wrong, so uninstalled the game & cleared all folders, then reinstalled it from scratch, adding only a single ER CDLC (but not the manager) and v1.23 RSMods, but get the same issue. I can't see that this is something others have experienced from searching around, but I really can't figure out what's wrong.

I did a quick desktop recording (no sound for some reason) to show what I mean: https://youtu.be/G4h_iBlWLRA

Everything else I can enable using RSMods seems to work well, like the fast load and exit button on the main menu.

Any help much appreciated!

MAR-VlN commented 3 years ago

Just did some more mucking around. Setting the CustomStringColors to 1 works, but editing the colours under 2 makes it work only in the tuner, before entering a song (interestingly, the colours revert to normal in the background after pressing delete to skip the tuner too).

I guess it just means that the custom colours have some compatability issue with ER, but the ZZ's color option works fine, so that'll do for now!

ffio1 commented 3 years ago

The colors revert back to default in the background because the way we check what menu you're in is by menu name. The menu name for the "Skip Tuning" box is used way too much for us to tell it to be used always in that menu.

MAR-VlN commented 3 years ago

That makes sense. I guess the bug is best defined as:

Custom Colours seem to cause the ER mode to stop working in-song/after the tuner (as per the YouTube video). ZZ's colours are unaffected and work properly.

ffio1 commented 3 years ago

That is definitely odd because, as far as I'm aware, those mods are handled the same way when it comes to displaying the texture. The only difference in the two methods is if we use predefined colors (ZZ colors) and in turn just create it from our own template. What makes it really weird is that I'm using custom colors 2, and if you're the same person who I was talking in Discord DMs with you had it set too, so it's weird that it works on my build and a lot of other people's but not on yours.

MAR-VlN commented 3 years ago

That is strange. I've not been on Discord so it wasn't me. Now it's working with ZZ's colours, I'll try the switching back to custom again tomorrow and see what happens. Don't see why it would make any difference, but as you say, I don't see why it wouldn't work anyway. I wonder what's making the difference between our installs/setups that causes it...

MAR-VlN commented 3 years ago

Is it possible that it's a GUI bug (again seems unlikely)? I edited the ini manually today when it started working, but I just can't remember if I tried it with the ZZ colours using the GUI to set it before. Something else to try tomorrow.

ffio1 commented 3 years ago

Oh okay, so this isn't a one person issue then, since I heard pretty much the same account from someone on discord a couple days ago. I'll look into this. I honestly don't think that function has been changed in months besides adding support for the coloring in the tuner.

As for if it's a GUI bug, I don't think it is. You're INI is going to have the right colors in it, if you set them. It would be the game registering it as either the wrong colors (I highly doubt this), or something happens between us creating the texture and us needing to use the texture that makes us drop it.

MAR-VlN commented 3 years ago

I didn't play any songs while messaging yesterday as it was late, but checking this morning, only the strings seem to be coloured, all the notes remain the same, which is a touch confusing.

Screenshot below.

ER Bug

Playing around with the GUI settings some more and now I'm back to having it working in the tuner, but no further, even with the colours on default...

MAR-VlN commented 3 years ago

I just reinstalled the mod again, and edited the config as per the attachment. It's still the same as the screenshot in the previous post, but it seems to do that whether it's an ER song or not (screenshots below are for Cemetery Gates by Pantera):

ER Bug Tuning E

ER Bug Song E

Actual ER songs are the same, the ER string colours show, but nothing else changes.

Current config as text file (Git doesn't support INI)

RSMods.txt

Lovrom8 commented 3 years ago

Alrighty, since strings and notes are separate, this means the tuning pointer works in both places, that's good. Can you try this DLL? It will generate a texture file in your RS folder called generatedTexture_d3d.dds. (open a 7-string song in RS just in case) If the bottom set of strings (6 strings + 2 that don't change) doesn't look like the colors you set in the GUI, then something's wrong with the texture generator, otherwise it's just not applying it for some reason.

D3DX9_42.zip

MAR-VlN commented 3 years ago

Just tried that with the config set to use ZZ colours, results are identical, with the string colours sticking no matter what tuning the song is in, but the notes don't change colour - they're always 'normal'.

Song in A Standard: ER Bug after DLL A

Song in E Standard: ER Bug after DLL E

Generated texture is attached: generatedTexture_d3d.zip

I then tried with custom colours instead, but it was the same as before (i.e. when I opened this thread), the ER string colours only appear in tuning on an ER song, but not once the song starts. All notes are as per 'normal'. The strings are the right colour on non-ER songs.

Generated texture with custom colours is also attached: generatedTexture_d3d 2.zip

MAR-VlN commented 3 years ago

I should add, thanks for the help so far guys, top work. I just wish I could be more helpful/useful too.