search

Lovrom8 / RSMods

383 stars 34 forks source link

Toggle extended range #95

Closed Th0rstenf closed 3 years ago

Th0rstenf commented 3 years ago

Introducing ToggleExtendenRangeKey in order dis- or enable extenden range mode on the fly.

Question: Does Settings::ToggleExtendedRangeMode() need additional operations to change colors during a song?

ffio1 commented 2 years ago

Hey @Th0rstenf. I slightly altered the functionality of this mod today. See: https://github.com/Lovrom8/RSMods/commit/220ac483ead7aa37f6eb10cc28512a0b0117433e

Old behavior: When the user presses the ToggleERKey, we changed the status of their settings to show that ER was turned on / off. This behavior means that a user who wants to turn on ER in a song that doesn't have a low enough tuning, couldn't do it in this song.

New behavior: When the user presses the ToggleERKey, we turn the ER mod itself on / off, not the setting. This means that a user could be in an E standard song, press their ER key, and now have ER colors.

One potential downside to this change is that when the user LEAVES a song, the ER mod will still be enabled (but not visible, if that makes sense). So if the user presses the key, they are only toggling ER status in THAT song, and is no longer a global "on/off" switch for the mod.

Please let me know if this negatively affects your experience, and I can relook at the solution to find the best of both worlds.