search

Ludy87 / xplora_watch

Xplora® Watch Home Assistant Integration
MIT License
47 stars 6 forks source link

Remove Unnecessary F-strings #398

Closed pixeebot[bot] closed 2 months ago

pixeebot[bot] commented 3 months ago

This codemod converts any f-strings without interpolated variables into regular strings. In these cases the use of f-string is not necessary; a simple string literal is sufficient.

While in some (extreme) cases we might expect a very modest performance improvement, in general this is a fix that improves the overall cleanliness and quality of your code.

- var = f"hello"
+ var = "hello"
  ...
More reading * [https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/f-string-without-interpolation.html](https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/f-string-without-interpolation.html) * [https://github.com/Instagram/LibCST/blob/main/libcst/codemod/commands/unnecessary_format_string.py](https://github.com/Instagram/LibCST/blob/main/libcst/codemod/commands/unnecessary_format_string.py)

Powered by: pixeebot (codemod ID: pixee:python/remove-unnecessary-f-str)

pixeebot[bot] commented 2 months ago

I'm confident in this change, and the CI checks pass, too!

If you see any reason not to merge this, or you have suggestions for improvements, please let me know!

pixeebot[bot] commented 2 months ago

Just a friendly ping to remind you about this change. If there are concerns about it, we'd love to hear about them!

Ludy87 commented 1 month ago

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.