search

LuisValgoi / ui5-webcomponents-react-seed

Seed of UI5 Web Components for React
12 stars 1 forks source link

Use CSS Variables for styling #48

Closed isaqueha closed 4 years ago

isaqueha commented 4 years ago

We should use CSS variables like var(--sapWarningColor). Refactor the use of colors, sizes, and other common values around the application. Example

style={{
    width: '1.5rem',
    height: '1.5rem',
    color: 'var(--sapWarningColor)'
})

{
--sapWarningColor: #feb60a;
}
isaqueha commented 4 years ago

Is this done? We don't need it anymore?

LuisValgoi commented 4 years ago

Yeah, its done