search

LuisValgoi / ui5-webcomponents-react-seed

Seed of UI5 Web Components for React
12 stars 1 forks source link

Investigate error during creation of a project using our template #70

Closed LuisValgoi closed 3 years ago

LuisValgoi commented 3 years ago

Describe the issue When you run npx create-react-app PROJECT_NAME --template ui5-webcomponents-react-seed It will work. It will create a project with our seed as template. But with an error at the console.

Expected behavior To work as its currently working, but, without the error.

Screenshots Screen Shot 2020-10-05 at 14 20 12

Additional context Add any other context about the problem here.

marceloschreiber commented 3 years ago

The error is caused due to the project not having git initialized. It is not initialized because of husky in the template.json.

After creating a new project from the template, there are 2 manual steps:

We can either document this as part of the process or write a bat/sh script that does this and document that it needs to be run after the project is created.

LuisValgoi commented 3 years ago

Solved and also will be ready once we migrate to seed. https://github.com/SAP/ui5-webcomponents-react/pull/790