Currently, there may be issues if a Loader dataset has no elements. Methods that require shape, (named for instance) will not work.
There is currently a temptation to create datasets as follows:
This fails because the named function is only valid after extend was called.
Removing extend from the Loader and instead pass ids via the constructor would avoid the scenario. Also, it conforms better to our otherwise functional API
LukasHedegaard
commented
4 years ago
Currently, there may be issues if a Loader dataset has no elements. Methods that require shape, (named for instance) will not work. There is currently a temptation to create datasets as follows:
This fails because the named function is only valid after extend was called.
Removing extend from the Loader and instead pass ids via the constructor would avoid the scenario. Also, it conforms better to our otherwise functional API