search

LuminosoInsight / sales-engineering-code

Code for sales engineering, particularly for code that will be given to customers
MIT License
0 stars 0 forks source link

Onsite script revisions #112

Closed Tahnan closed 4 years ago

Tahnan commented 4 years ago

Probably worth seeing individual commits, which are separate work (the last commit has more details explaining its changes in its commit message).

Note that this does not remove the --token option for specifying a token at the command line; I think there still needs to be a discussion about whether that's ever the right thing to do, or whether the script should fall back to either an environment variable, if one exists, or the LuminosoClient's saved token, if one exists.

wharter commented 4 years ago

@Tahnan All these changes look good. I don't see any reason not to merge. I liked the changes the argument passing.