search

LuminosoInsight / sales-engineering-code

Code for sales engineering, particularly for code that will be given to customers
MIT License
0 stars 0 forks source link

updated v4 code to v5, fixed max text len, cleaned code, fixed csv error #140

Closed wharter closed 3 years ago

wharter commented 3 years ago

There were a bunch of issues with this create_project script.

  1. Updated v4 code to v5
  2. Fixed max text length code that was commented out
  3. Found a problem with csv reading
  4. Cleaned code formatting
Tahnan commented 3 years ago

@wharter : I've added a commit with something of an overhaul. It's not quite identical in behavior--for instance, it accepts multiple columns with the same heading, rejects spreadsheets with multiple "text" columns, omits blank metadata rather than treating it as a "0". There's a whole lot of refactoring, pulling things out into separate functions, which in a better world would have been kept commit-by-commit rather than appearing in one large chunk; but alas.

I'm going to bounce this back to you for review; let me know if there's anything that looks wrong, or is confusing and needs comments, or doesn't function the way you'd want.

wharter commented 3 years ago

Looks great. I can't add any value.