search

LuminosoInsight / sales-engineering-code

Code for sales engineering, particularly for code that will be given to customers
MIT License
0 stars 0 forks source link

Add reptree code and the topic_generator script #16

Closed rspeer closed 8 years ago

rspeer commented 8 years ago

This is a script that Alice asked for, which can use reptrees to suggest topics or even automatically create them.

Requires scipy to be installed separately.

Tahnan commented 8 years ago

I didn't review the reptree code, since I gather it was copied directly from another repo and has therefore been sufficiently vetted. That did cause Andrew to wonder whether it made sense to not copy it and instead declare reptree2 as an optional dependency of se_code instead. I have no feelings on this one way or another; I'm just passing along the idea for consideration.

Otherwise, aside from a couple of small comments I left above, the topic_generator script looks good.

rspeer commented 8 years ago

Talked to Jason about whether to make reptree2 a dependency, and we agreed not to. It would make the script harder to use, and would involve the additional work of cleaning up the rest of reptree2.

I'll deal with the option for a different API.