LuminosoInsight / sales-engineering-code

Code for sales engineering, particularly for code that will be given to customers
MIT License
0 stars 0 forks source link

adding new files created for some clients #63

Closed boazinho closed 5 years ago

boazinho commented 5 years ago

each file in Jupyter & .py format

lumi-kwang commented 5 years ago

Don't upload 2 versions of the same script, we don't need the .ipynb and the .py version. Try to convert notebooks to .py scripts (not everyone is guaranteed to have Jupyter). Don't hardcode anything, these should be scripts that are re-usable by any client with the only changes being in input. Try to clean them up to remove duplicate imports, as well as unnecessary comments.