Support for MPI_Errhandler_set and MPI_Intercomm_merge

MCSclimate / MCT

Model Coupling Tookit

Other

43 stars 18 forks source link

Support for MPI_Errhandler_set and MPI_Intercomm_merge #34

Closed Katetc closed 8 years ago

Katetc commented 8 years ago

This commit adds support for the following MPI functions,

MPI_Errhandler_set : Currently, the function just returns success and does nothing. Future work should implement this and other MPI_Errhandler functionality. Also adding MPI_ERRORS_ARE_FATAL, MPI_ERRORS_RETURN types.
MPI_Intercomm_merge: A no-op that assigns the existing inter comm to the new/merged comm

jayeshkrishna commented 8 years ago

@Katetc : Please review the changes that I made to the title and the PR message and modify it as needed.

jayeshkrishna commented 8 years ago

The mpi-serial tests (make tests) run fine.

jayeshkrishna commented 8 years ago

@rljacob / @Katetc : Do you know why when I try to merge the branch manually (following "command line instructions" next to the "Merge button") I see that around 40+ commits are merged?

rljacob commented 8 years ago

What does "git log" show after the merge to master? If its just the 2 commits on this branch, you're ok.

jayeshkrishna commented 8 years ago

It looks like only the changes in this PR were brought in (diff of dirs only show the changes in this PR). Just curious why git shows merging of 40+ commits, so that history is clean. I will go ahead with the merge then. (git log shows only the changes from this PR after the latest commit on master)

jayeshkrishna commented 8 years ago

Looks like I was merging to a different/old repo (git://git.mcs.anl.gov/MCT.git). I will retry locally merging to the https://github.com/MCSclimate/MCT repo. Sorry for the confusion :)

jayeshkrishna commented 8 years ago

The mpi-serial tests ran successfully on my laptop (after local merge to master)