search

MESH-Model / MESH-Dev

This repository contains the official MESH development code, which is the basis for the 'tags' listed under the MESH-Releases repository. The same tags are listed under this repository. Legacy branches and utilities have also been ported from the former SVN (Subversion) repository. Future developments must create 'forks' from this repository.
Other
2 stars 3 forks source link

Subl in MESH ET output #1

Closed dprincz closed 1 month ago

dprincz commented 1 year ago

Submitted on behalf of @mee067.

It seems something went wrong either with the units or the tile fractions, or maybe something else. I was comparing 1860 to 1813 for the Yukon and it looks fine. I thought I would test it on some part of the MRB too so I did for the Great Bear Lake basin (GBL). PBSM is off for the Yukon but it is on for the GBL. ET in the water balance looks crazy. I switched off PBSM and it become normal. I tried to investigate in the code but couldn't figure out what could be wrong. CLASS output (tile level) looks fine. Subl and Drift are passed to CLASSZ for WB checks and I got now errors from CLASSZ. I think it is all on the output level (when accumulating to grids or to basins).

Attached are the results from the same run once with PBSM and once without. r1813 results for both cases are also in the file (subl in not added to et in that code – there are still differences to et, stemming from changes to snow).

1860vs1813-PBSM.xlsx

mee067 commented 1 year ago

I think subl should be divided by DELT. QFS is defined as kg/m2/s while subl is defined as kg/m2.

mee067 commented 1 year ago

I also found that CLASS output prints QFS, i.e. Subl is not included. OUTFILESFLAG outputs for tiles use et which includes Subl and therefore they won't match if PBSM is on.

dprincz commented 1 month ago

This was resolved in the "ME" changes being integrated into the main branch of the code.