MESH-Model / MESH-Dev

This repository contains the official MESH development code, which is the basis for the 'tags' listed under the MESH-Releases repository. The same tags are listed under this repository. Legacy branches and utilities have also been ported from the former SVN (Subversion) repository. Future developments must create 'forks' from this repository.
Other
2 stars 3 forks source link

feat: Re-adding SUBBASINFLAG using the GRU-based masking approach #12

Closed dprincz closed 1 year ago

dprincz commented 1 year ago

Closes #10

mee067 commented 9 months ago

Unfortunately, routing zero flows did not work for long. After 4 years of simulation, it caused a NON-CONV crash for a point outside the basin of interest:

route yields a negative store2 value at dtmin = mindtmin:   10.0
 It's likely that qo1 is so large that store2 is negative even with qo2=0.0
If this run was started from  shed2flowinit utility, then try lowering the QI,  QO, and STORE ratios until this error is resolved
 Else rerun with a smaller value of dtmin

The point of the crash is just d/s of a lake outlet. Disabling lakes might resolve the issue but this entails changes to the ddb which is unwanted (changing the reach field name). I am testing it though.

mee067 commented 9 months ago

disabling the Reach field resolved the issue for the basin of interest but what if the basin of interest contains lakes. I guess it won't always work.