MESH-Model / MESH-Dev

This repository contains the official MESH development code, which is the basis for the 'tags' listed under the MESH-Releases repository. The same tags are listed under this repository. Legacy branches and utilities have also been ported from the former SVN (Subversion) repository. Future developments must create 'forks' from this repository.
Other
2 stars 3 forks source link

Name of STREAMFLOWOUTFLAG in wiki #24

Open roalva82 opened 7 months ago

roalva82 commented 7 months ago

The description provided in https://wiki.usask.ca/display/MESH/MESH_input_run_options.ini indicates that: "" STREAMFLOWFLAG:

IF STREAMFLOWFLAG = 0, MESH will output a daily streamflow file only. IF STREAMFLOWFLAG = 1, MESH will output daily and half-hourly streamflow files. (Or a streamflow file showing streamflow for each timestep if your timestep is not half-hourly.) By default, the STREAMFLOWFLAG = 0. "" I believe the name of this flag should be STREAMFLOWOUTFLAG, instead of STREAMFLOWFLAG.

kasra-keshavarz commented 6 months ago

Based on @mee067:

I checked the wiki for STREAMFLOWOUTFLAG 2 and if I understand correctly, it produces streamflow at the model time step. You can achieve that with STREAMFLOWOUTFLAG ts . This reinforces my idea that it is a legacy option that has been replaced. The default streamflow output is daily.

Thought it could be relevant.

kasra-keshavarz commented 6 months ago

More from @mee067:

I looked at the r1860 code: STREAMFLOWFLAG no longer exists, specifying it means you are not specifying STREAMFLOWOUTFLAG and so the default is used. STREAMFLOWOUTFLAG default is daily Options include: ts for output at the model time step bal ?? acc outputs accumulated time series - not sure if it resets at certain times or continues all activates three flag properties (bal, hyd, and acc) at both frequencies (daily and ts) - not sure what is hyd either

additional options include no_header to switch off the header row that contains the gauge numbers, and none to switch off the streamflow output althogether - saving space in case of calibration. Metrics_out.txt will still be written - that's controlled by the AUTOCALIBRATIONFLAG

As you see, these are not fully documented and from the code, I see some combinations may not be functional (e.g. ts acc). I have not tested other than the default (daily) and the time step option (ts).

I think there was some work in progress but it was not completed. We have other output frequencies (hourly, monthly, seasonal, annual) that can be used with OUTFIELDSFLAG but not with the streamflow output reinforcing the idea that the work was not complete for this flag. At least the basic functionality at daily and time step is there.

mee067 commented 6 months ago

Thanks @kasra-keshavarz for copying these here. Slack is volatile as we are not paying to keep the full history.