Open kaijagahm opened 3 years ago
kaijagahm
commented
3 years ago I did a first pass through this file and made some comments. Also passed it to @Randinotte, who will look at it when she has time (no rush). Aiming to bring this up at the next meeting: maybe we could look at it in real time and determine which, if any, of these issues should be added to Github as "issues".
kaijagahm
commented
3 years ago Discussed this at the 2/23 meeting.
Reproducing the doc here so we can strike things off:
~Write R scripts for database ‘checks’ that are similar to Access (Alex / Jake)~ (this is being dealt with in #99).
~Get dome data from shonde~ ~"shonde" is a nickname for Sean Godwin. "Dome data" refers to data from a benthic dome experiment, which goes in the sensor database. Steps for dealing with this: 1. Find a paper with Sean Godwin, SEJ, and CTS as authors, and read that paper to determine which years Sean's dome data was from. Then, go into the sensor database and figure out whether the dome data from those years is already in there, or not. If not, then the next step will be talking to SEJ or others to find said data.~ EDIT: The data seem to already be in the sensor database. I looked at DO_CORR, filtered it down to the 11 study lakes described in the attached paper and to the specified dates (2012 and 2013). Indeed, I see DO data from every 5 minutes, as indicated in the paper. I did not dig further into the other data types, but I'm assuming that if the DO data was successfully entered, then so was the rest. lo.2014.59.6.2112.pdf
~Fix stream discharge as it seems to be rounded off when above 0.01 m3 s-1 (Jake)~ (Moved this over to #124)
~Check if datetime is correct in sensor database (some with unnecessary seconds at the end - round to nearest 5/10 mins) (Jake / Alex)~ (Moved this over to @125)
~Fix Color datetime - most times are 00:00 (Alex) @kaijagahm will look into this. Check whether the time is always 00:00 including in the SAMPLES table. If there are times in the SAMPLES table but not in COLOR, then can fix them in COLOR. If no times anywhere, then just leave as is.~ EDIT: Only 80 rows (out of 2752 rows total in COLOR) have 00:00:00 in dateTimeSample, and all of those also have 0000 in the sampleID. Since I've already done relational checks between COLOR and SAMPLES, that means that the 0000 is also in SAMPLES. So these can be left as is.
TN data is really high in 2013 (see long data). Joey re-ran the 2013 TN data and it looks a lot better. Include the rerun data along with notes about the rerun in the TN data table @Randinotte will check into this.
Looks like 2015-05-27 EL Hypo/PML switched around - according to color data (I switched color data around already). Watch out for the other data that is coming in! i.e. DOC, nutrients, etc… @Randinotte will check into this.
~Add new LENGTH_DRYMASS table connection to OTU table (Alex)~ Assume this has already been dealt with since we have DRY_MASS_EQUATIONS. There may be some updates to this table at some point, but we're not going to pursue these additional connections.
~FISH_INFO - use file from Nikki's email on Feb 20, 2015 (Jake’s email)~ Assume this has been dealt with, and in any case we don't know which files this refers to.
Fix zeros for DO,temp, DO% in SQLite version of DB @ 0.25 and 0.75. We measure PAR at 0.25 and 0.75 but leave DO / temp / etc… blank. The SQLite version fills in 0 automatically but we should be filling in NA’s here. @Randinotte will look into this.
~TYPO - in database - WL limnoprofile 2013-09-16 depth 6 is at a temperatue of 67C , should be 6.7C @kaijagahm will look into this.~ EDIT: Made this fix in thingsToDo_gh111.R. Will incorporate it into the next db version.
GC database - change run07081401 and run 07091401 and run 07101401 sequence (suffix name is wrong on all samples) (Jake)
@kaijagahm and maybe work with @Randinotte: take a look at those dates and see if the problem is obvious.
EDIT: I looked at this and I think that they were saying we should replace the suffix on the runName with the runID number. I'm not totally sure, because standards for run names have changed over the years. I looked at a random sample of runNames in thingsToDo_gh111.R, and it looks like some of them incorporate the runID number, but not all do. Some of them look like they're trying to, but digits are missing from the beginning or end. This needs more discussion and should probably be lumped in with the remaining primary key problems in #99 .
~Put new table in database for Ice Off (and ice on if we have it) - Ice Off (greater than 75% open): 2013 - May 8 for Morris, May 9 for Long; 2014 - May 6 for Morris, May 8 for Long~ (We've decided not to add this table).
kaijagahm
commented
3 years ago This issue has a script started. See 'gh111_thingsToDo.R' in my archive.
I found this file in the Box metadata folder, with a list of database-related tasks. I wonder if any/all of these got finished. Some of them look like we could tackle them now. Others refer to files from people's emails that I don't think we have access to.