search

MPEGGroup / FileFormatConformance

MPEG File Format Conformance Framework
https://mpeggroup.github.io/FileFormatConformance/
BSD 3-Clause Clear License
10 stars 3 forks source link

[Website] btrt box missing in coverage but present #19

Closed cconcolato closed 1 year ago

cconcolato commented 1 year ago

Summary

The btrt box is said to not be tested, but that file https://gpac.github.io/mp4box.js/test/filereader.html?https://mpeggroup.github.io/FileFormatConformance/files/published/isobmff/21_segment.mp4 does have it.

Steps to reproduce

Search for btrt you get

image

but load the 21_segment.mp4 and you'll see it:

image
DenizUgur commented 1 year ago

This is a known bug at this moment. This is because the box btrt has defined a container of SampleEntry on standard features. However, there are no box that specify SampleEntry as its type (explicitly). The algorithm doesn't do a partial match but an exact match.

There are two ways to solve this problem:

  1. Explicitly define each SampleEntry (e.g. VisualSampleEntry) for btrt. This would be an easy fix but at the same time we would deviate from the specification.
  2. Parse every available syntax to create a type hierarchy. Using that information, previous manual fix could be automated.

@podborski what do you think we should do here?

https://github.com/MPEGGroup/FileFormatConformance/blob/7c7c9abb3d795840a74027e67cd41dabb61b237f/data/standard_features/14496-12/boxes.json#L386-L392

podborski commented 1 year ago

Done in the last PR. Please re-open if problem still there.