Cleanups - Githubissues

MPEGGroup / FileFormatConformance

MPEG File Format Conformance Framework

https://mpeggroup.github.io/FileFormatConformance/

BSD 3-Clause Clear License

10 stars 3 forks source link

Cleanups #50

Closed podborski closed 12 months ago

podborski commented 1 year ago

Initial clean ups for user-defined features which are now redundant as those can be found using the presence of the 4CCs which we already parse.
~add new issue template, improve existing templates~ (cherry picked, merged)
make unrecognized features fail the pipeline
fix all user-defined features in all files
add missing boxes

podborski commented 1 year ago

@DenizUgur could you take a look how to resolve the failing test. I moved out sample entries defined in ISOBMFF to codecs.json in this commit 5ef2d49, and it seems to not like it.

DenizUgur commented 1 year ago

This happened because in that commit you removed the only entry that listed its type as SampleEntry. I'll have to check if this error can be silenced. There is another hierarchical check for these kind of indirect type matches. Maybe this was a corner case.

{
    "fourcc": "encs",
    "description": "Encrypted Systems stream",
-   "type": "SampleEntry",
    "containers": ["stsd"],
    "syntax": "TODO: Bug. see 'rest'"
}