search

MPIBGC-TEE / bgc_md2

New development version of the biogeochemical model database bgc_md
GNU General Public License v3.0
8 stars 21 forks source link

add xi to IBIS #106

Open viatkin opened 2 years ago

viatkin commented 2 years ago

Hi Chengyu,

Thanks lot for working on IBIS model and bringing it to a very good shape! I can help you complete test_helpers.py and other necessary function to add the model to the comparison. However, I noticed that you don't have any environmental scalar (xi) in the code. Temperature sensitivity is an important aspect of our analysis, so having 0 sensitivity (as it is now without xi) would not look reasonable for your model. Do you have any information on how to compute environmental scalars in IBIS? Any temperature- or moisture-dependent equations would be helpful.

Thanks!

cyBian commented 2 years ago

Hello Kostia,

Sorry for the late response. I have added the environmental scalars of the IBIS model to the model_spectific_helps.py. In the IBIS model, environmental scalars regulate microbial decomposition activity based on the soil temperature and moisture. Considering that the model did not provide the soil temperature, thus I used the near-surface air temperature as a surrogate in this version. You can find the specific information in the code.

Best, Chenyu

viatkin commented 2 years ago

Hello Chenyu,

Thank you very much! I started data assimilation with your new xi function. It is going very slowly for some reason. Let's wait and see if we can fit the model well.

Best, Kostia

cyBian commented 2 years ago

Sure, let's see what happens.